search

zooniverse / shakespeares_world

Full text transcription project for the Folger Shakespeare Library
https://www.shakespearesworld.org
Other
8 stars 5 forks source link

Saved graphic annotations don't re-render on page load #359

Closed camallen closed 6 years ago

camallen commented 6 years ago

If i come back to a subject and select to reload my work any saved (local storage) graphic annotations are not reloaded nor drawn on the UI. Instead they are cleared and a new subject is loaded and i lose my work :(

simoneduca commented 6 years ago

My bad. This is because graphic annotations, unlike text annotations, are missing a subjectId property against which to check. I'll add that in.

simoneduca commented 6 years ago

Mmm turns out adding the subjectId gets you the warning when you have unsaved graphic notations, but the drawing is still missing.

simoneduca commented 6 years ago

The fact that Annotate is showing the same bug makes me think a library (perhaps hammerjs ?) has broken somehow.