search

zooniverse / shakespeares_world

Full text transcription project for the Folger Shakespeare Library
https://www.shakespearesworld.org
Other
8 stars 5 forks source link

Version number is baked into local storage keys #370

Open eatyourgreens opened 6 years ago

eatyourgreens commented 6 years ago

https://github.com/zooniverse/shakespeares_world/blob/df70a2046bd2263811c8634a3d366b6568c1164c/app/modules/app.config.js#L20-L21 So, any stored data on volunteers' browsers will be unreadable if the version number is changed, and the old keys won't be deleted by the current code.

Simplest solution is probably never to change SW's version number. 😞

simoneduca commented 6 years ago

Why would removing the version bit not work?

eatyourgreens commented 6 years ago

That would change the key names, leading to the same problem.