search

zooniverse / talk-api

Apache License 2.0
6 stars 0 forks source link

Set host before attempting request #240

Closed zwolf closed 4 years ago

zwolf commented 4 years ago

Fixes local spec failure for MarkdownApi by setting the host env var before attempting request.

camallen commented 4 years ago

i believe this error was fixed by the changes in #239

zwolf commented 4 years ago

Looks like it should be, but I can't build master and run the specs without first doing a bundle install from a bash prompt in the container from the master branch right now. Specs all pass locally though so this PR is superseded by that one and I'll close this.

camallen commented 4 years ago

Looks like it should be, but I can't build master and run the specs without first doing a bundle install from a bash prompt in the container from the master branch right now. Specs all pass locally though so this PR is superseded by that one and I'll close this.

I've added instructions to the readme in https://github.com/zooniverse/talk-api/pull/241. the bundle install is required as we now cache the gems in a volume via https://github.com/zooniverse/talk-api/blob/f44b6a665cc98eb7c29e4e3211bf2933100c8b67/docker-compose.yml#L26 this won't auto update even with new docker image builds (unless you recreate the volume) but will save install times when doing dev work and the bundle changes.