search

zooniverse / talk-api

Apache License 2.0
6 stars 0 forks source link

remove length constraints on FDW project varchar fields #263

Closed camallen closed 3 years ago

camallen commented 3 years ago

panoptes db doesn't have length constraints so talk fdw should not enforce any for row values that may exceed this and thus error

https://github.com/zooniverse/panoptes/blob/4b3c799f796214c033ed57fda2c2ddcbe7693a7e/db/structure.sql#L1027-L1041

I tested this locally by building the docker images and creating local versions of the db with the instructions in https://github.com/zooniverse/talk-api/#setting-up. Everything is working well and matches with the changes on the production system.

camallen commented 3 years ago

Looks good, but isn't going to actually stop any errors unless we rebuild the whole FDW setup, right? Is this causing enough of a fuss to rebuild the FDW portions of the Talk db?

I manually applied this on the talk db FDWs a while back to fix a recurring bug with a live project https://www.zooniverse.org/talk/17/1922381?comment=3131277