Panoptes auth - Githubissues

zooniverse / vox

Voting app

Apache License 2.0

0 stars 1 forks source link

Panoptes auth #30

Closed simoneduca closed 7 years ago

simoneduca commented 7 years ago

Struggling to find the correct flow for keeping Firebase and Panoptes user in sync. Atm the user can login/out Panoptes but it's locked out of Firebase.

camallen commented 7 years ago

@simoneduca happy to help sort this out with you.

simoneduca commented 7 years ago

@rogerhutchings this should be ready to go.

simoneduca commented 7 years ago

By the way, the hound is complaining mostly about console statements. As for the dependencies I can open a new PR later.

rogerhutchings commented 7 years ago

Okay, this seems to work!

Login button doesn't change to logout
The same user store in Redux holds the firebase user and panoptes user at different times. They should probably have their own properties inside user, it may not be clear which is being referred to at a given time in the code

simoneduca commented 7 years ago

Excellent, thanks. That's what I'm working on fixing atm

simoneduca commented 7 years ago

I was also thinking about how to split config values based on env var.

rogerhutchings commented 7 years ago

lgtm