search

zooniverse / wildcam-gorongosa-education

This is WildCam Labs, the education/exploration-oriented extension of the WildCam Gorongosa project.
https://lab.wildcamgorongosa.org/
Apache License 2.0
0 stars 1 forks source link

Assignment form #225

Closed simoneduca closed 8 years ago

simoneduca commented 8 years ago

This basically me playing around with the concept of assignment. It includes a workable assignment form, but ultimately assignments will have their separate store (actions and reducers). Since the idea of assignments has also be honed further thanks to chats with others in the team, I might close this PR and reopen a new cleaner one in the next day or so.

simoneduca commented 8 years ago

@eatyourgreens @rogerhutchings @shaunanoordin if anybody feels brave this is ready. It's inoffensive stuff really. Note: the edu-api has a bug now, so when you create an assignment you get a 500 atm, but don't worry the call is correct.

shaunanoordin commented 8 years ago

Woot, we're getting assignments! Nice, @simoneduca

Here's some feedback and some queries.

  1. Accessing the New Assignment feature is pretty straightforward for Educators, good.
  2. [ui] The 'Date' field in the New Assignment form is Month-Day-Year? I'm in favour of YYYY-MM-DD, but I'm OK with this format if this suits our users' locale better. I'll make sure the date format across the rest of the website is consistent.
  3. [error] Attempting to create a New Assignment with valid Name/Description/Date/NumOfClassifications and 1+ Students creates: 500 Error, https://education.staging.zooniverse.org/assignments/
  4. [error] However, when an attempt to create a similar Assignment with 0 Students creates a 422 Error (Unprocessable Entity), https://education.staging.zooniverse.org/assignments/
  5. Q: the wiring to the EduAPI is still a WIP?
  6. [minor][ui] When clicking on a Student name to select ("assign") said Student, I'd recommend styling the pointer to pointer: cursor. (Or was that cursor: pointer? I can never remember.)
  7. [accessibility] The list of selectable students in the New Assignment form is actually a list of <td>s, which might be improved if they were, e.g. <button>s... or perhaps a list of <label><input checkbox>s.
  8. I have been unable to test Assignments from a Student perspective, unfortunately, due to points 3 and 4.

screen shot 2016-06-29 at 17 15 45 Note that hovering over the students zootester1, zootester2, zootester3 would not clearly indicate to the user that the names can be clicked.

simoneduca commented 8 years ago

@eatyourgreens @rogerhutchings @shaunanoordin I've included your comments, thanks a lot.

simoneduca commented 8 years ago

@eatyourgreens hopefully the last commit should do it. Mind having a look?

simoneduca commented 8 years ago

@eatyourgreens better?