Code cleanup - duplicate "Hardcode Subjects for staging Assignments" - Githubissues

zooniverse / wildcam-gorongosa-education

This is WildCam Labs, the education/exploration-oriented extension of the WildCam Gorongosa project.

https://lab.wildcamgorongosa.org/

Apache License 2.0

0 stars 1 forks source link

Code cleanup - duplicate "Hardcode Subjects for staging Assignments" #326

Closed shaunanoordin closed 4 years ago

shaunanoordin commented 6 years ago

Code Cleanup Required

Following PR #325 , there are now TWO instances of code that hardcodes a specific selection of Subjects when creating Assignments on staging.

In assignments.js, 'sampleSubjects' from the WildCam Gorongosa (staging) is used to make API calls to the Edu API.
In AssignmentForm.jsx, Subjects from the "Is It Bacon?" project is used to allow the Assignment creation/editing form to validate/submit.

Recommended solution

Logic from assignments.js could be moved to AssignmentForm.jsx, OR
Validation check on AssignmentForm could be removed altogether. (Assuming we're OK to allow users to create Assignments with 0 Subjects.)