search

zooniverse / zooniverse-readymade

Apache License 2.0
1 stars 3 forks source link

Use window.zooniverse when possible #37

Closed parrish closed 8 years ago

parrish commented 8 years ago

Instead of overriding customized components, this causes requires to consistently prefer already defined modules.

eatyourgreens commented 8 years ago

Works fine in a quick test with Science Gossip. I still need to test Penguin Watch translations, since I vaguely remember that readymade might have hacked the zooniverse variable to make those work (could be wrong on this.)

Is there any reason not to just do this in zooniverse/Zooniverse ? eg. module.exports = window.zooniverse.Api here https://github.com/zooniverse/Zooniverse/blob/master/src/lib/api.coffee#L53

eatyourgreens commented 8 years ago

Penguin Watch translations look fine to me too, so this looks good to merge.

parrish commented 8 years ago

I approached it from readymade since it was defining/overriding the modules too. Mind releasing a version bump?

eatyourgreens commented 8 years ago

@parrish published as 1.2.0. Cheers!