search

zoonooz / ZFRippleButton

Custom UIButton effect inspired by Google Material Design
MIT License
1.41k stars 110 forks source link

make setup public #13

Closed jpaas closed 9 years ago

jpaas commented 9 years ago

The setup method is a nice function to override for subclasses that extend the button. I'd like to suggest it be made public.

zoonooz commented 9 years ago

Hi @jpaas for me I think setup() should not be made public. The method can be called one time only for initialise required value. The safest way is override init and do some custom stuff there after call super.

jpaas commented 9 years ago

Yep that works. Thanks!