search

zoonproject / zoon

The zoon R package
Other
61 stars 13 forks source link

User defined attributes in df not propagated #331

Closed RTbecard closed 7 years ago

RTbecard commented 8 years ago

User defined attributes (as opposed to hard-coded attributes like covCols) don't propagate through the workflow.

In line 387 (zoonHelpers.R), the cbind strips the attributes, and user defined attributes in occurrence of process modules never get recovered (only the covCols attribute get recovered).

I'll write up a pull request for this today or tomorrow, as fixing this is necessary for allowing support of detection models.

AugustT commented 8 years ago

Did you get anywhere with this @RTbecard ?

RTbecard commented 8 years ago

yes! I have it done and working a while ago! I've held off on giving a PR, as I saw you guys were taking a break and I wanted to be sure it was working quite well by thoroughly testing it on my data.

I'll do a PR tonight, as I'll have to look over it and make sure the branch is clean and i haven't added any extra unnecessary stuff since then (commenting out try catch clauses etc.).

AugustT commented 8 years ago

Great stuff!

RTbecard commented 8 years ago

If you want to take a peek before then, its in my SimulatedData branch.

goldingn commented 8 years ago

:+1:

AugustT commented 7 years ago

I think this should be closed