implementing good practice guidelines

[goldingn]

To fix #349

[goldingn]

Still to do:

• [ ] replace overlength lines in tests
• [ ] replace all sapply statements with vapply

Debatable:

• [ ] remove date from description
• [ ] switch dependencies to imports
• [ ] make test_outputs less complex

[AugustT]

How have I never used vapply?!

[goldingn]

(I'm still planning to get to this soon BTW)

[codecov-io]

Codecov Report

Merging #353 into master will decrease coverage by 1.15%. The diff coverage is 93.7%.

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
- Coverage   94.22%   93.07%   -1.16%     
==========================================
  Files          27       28       +1     
  Lines        2478     3638    +1160     
==========================================
+ Hits         2335     3386    +1051     
- Misses        143      252     +109

Impacted Files	Coverage Δ
R/Replicate.R	100% <ø> (ø)	:arrow_up:
R/zzz.R	0% <0%> (ø)	:arrow_up:
R/FindExtent.R	0% <0%> (ø)
R/ZoonFigshare.R	0% <0%> (ø)	:arrow_up:
R/RerunWorkflow.R	96.13% <100%> (+1.39%)	:arrow_up:
R/attributeFunctions.R	100% <100%> (ø)	:arrow_up:
R/ZoonCitation.R	100% <100%> (ø)	:arrow_up:
R/test_outputs.R	100% <100%> (ø)	:arrow_up:
R/CombineRasters.R	99.13% <100%> (+0.94%)	:arrow_up:
R/test_module.R	100% <100%> (ø)	:arrow_up:
... and 22 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d0e2c3...6d3267f. Read the comment docs.

[goldingn]

this is now merged with my master branch, for which I'll open a PR