search

zoonproject / zoon

The zoon R package
Other
61 stars 13 forks source link

module tests error on predict.gbm #366

Closed goldingn closed 7 years ago

goldingn commented 7 years ago

It looks like the gbm maintainers have pushed the results of their recent package refactoring to CRAN. This includes such breaking changes as renaming the fitted model objects from gbm toGBMfit. Consequently We now have this error on the Travis build for the GBM module:

1. Error: Check MODEL output formats for GBM.R ---------------------------------
'predict.gbm' is not an exported object from 'namespace:gbm'

The fix for this should be a fairly straightforward swtich to predict.GBMfit, though there may be other changes

goldingn commented 7 years ago

My bad, the breaking version of gbm (v2.2) isn't yet on CRAN so this should still work until that happens