Subsetting GetModuleList()

[Doi90]

It would be good if we could subset GetModuleList() with an argument rather than sub-setting a saved list. If I want to see just occurrence modules then I need to run this:

tmp <-GetModuleList()
tmp$occurrence

Ideally we could do something like this:

GetModuleList(type = "occurrence")

Makes it neater when using it in the vignettes we're building.

[AugustT]

Sounds like a good idea to me

[timcdlucas]

I certainly tried (and clearly failed) to do this back in the day. GetModuleList downloads the .Rd files. I think the only bit in there that guarantees to identify the module type is

Other process: \code{\link{AddRandomUniformPredictors}},

Does that seem right @AugustT ?

[AugustT]

I was thinking much more simple than that. Put type in at the end

GetModuleList(type = "occurrence"){
    ...
    return(tmp[type])
}

But then I am a lazy coder!

There might be a way to identify all the correct .rd files and then just download them, which would obviously be more efficient. But the .rd files are pretty small at the moment...

[timcdlucas]

Oh right! Forgot GetModuleList does already do the grouping. Yup, your way sounds fine,

[goldingn]

Sounds ace. Want to take a swing at implementing this @doi90?

If so, check out match.arg() for type checking the argument.

[Doi90]

I'll swing away.

[Doi90]

Submitted a pull request with the ability to subset by module type. Assuming it passes Travis checks and people are happy with my approach I'll close this issue

[goldingn]

this is in master now