zoonproject / zoon

The zoon R package
Other
61 stars 13 forks source link

Changed GetModuleList() to be subsettable by module type #387

Closed Doi90 closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #387 into master will decrease coverage by 0.02%. The diff coverage is 93.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
- Coverage   94.25%   94.22%   -0.03%     
==========================================
  Files          27       27              
  Lines        2435     2478      +43     
==========================================
+ Hits         2295     2335      +40     
- Misses        140      143       +3
Impacted Files Coverage Δ
R/SearchFunctions.R 93.97% <93.58%> (-1.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d3fab4...73487bc. Read the comment docs.

AugustT commented 7 years ago

Good job, it looks to pass the travis tests but the test coverage has dropped. Do you want to write a test that covers the new functionality you added?

AugustT commented 7 years ago

You can see the red lines not covered in testing here: https://codecov.io/gh/zoonproject/zoon/pull/387/src/R/SearchFunctions.R

Doi90 commented 7 years ago

Since I don't see codecov mentioned anywhere in the repository, I assume I have to modify this file?

https://github.com/zoonproject/zoon/blob/master/tests/testthat/testGetModuleList.R

AugustT commented 7 years ago

Yes that's right. That script runs the tests for the GetModuleList function. It uses the package 'testthat' to do it and the help files of that package will help you understand how it works. CodeCov is a service, like travis, that monitors a repository on GitHub. CodeCov looks at your tests and works out which lines of your code it is checking. A good coverage is over 90%, we fought hard to get there so I'm keen to keep it that way.

Let me know if you run into any problems.

AugustT commented 7 years ago

Good job, -0.03% I can live with ;) Thanks for taking the time to go the extra step