Closed Doi90 closed 7 years ago
Good job, it looks to pass the travis tests but the test coverage has dropped. Do you want to write a test that covers the new functionality you added?
You can see the red lines not covered in testing here: https://codecov.io/gh/zoonproject/zoon/pull/387/src/R/SearchFunctions.R
Since I don't see codecov mentioned anywhere in the repository, I assume I have to modify this file?
https://github.com/zoonproject/zoon/blob/master/tests/testthat/testGetModuleList.R
Yes that's right. That script runs the tests for the GetModuleList function. It uses the package 'testthat' to do it and the help files of that package will help you understand how it works. CodeCov is a service, like travis, that monitors a repository on GitHub. CodeCov looks at your tests and works out which lines of your code it is checking. A good coverage is over 90%, we fought hard to get there so I'm keen to keep it that way.
Let me know if you run into any problems.
Good job, -0.03% I can live with ;) Thanks for taking the time to go the extra step
Codecov Report
93.97% <93.58%> (-1.03%)
Continue to review full report at Codecov.