search

zoonproject / zoon

The zoon R package
Other
61 stars 13 forks source link

Some line endings can break modules. Should be tested for. #421

Open timcdlucas opened 6 years ago

timcdlucas commented 6 years ago

I don't know exactly what went wrong but this version of a module has some \r line endings that broke LoadModule.

https://github.com/zoonproject/modules/blob/c1bca5e8776f6967be488b932ff92ad63b66f70d/R/LonLatToCovariates.R

Discussed in PR https://github.com/zoonproject/modules/pull/166

This particular instance fixed in https://github.com/zoonproject/modules/pull/167 I hope.

But we should add a test in test_module for this once we've worked out exactly what is and isn't allowe.d