Closed antFrancon closed 1 month ago
@antFrancon Are you using Expo?
@antFrancon Are you using Expo?
Oh yes, of course, I forgot that. I am using Expo Bare Workflow. So I did the native iOS setup
- (void)customizeRootView:(RCTRootView *)rootView {
[RNBootSplash initWithStoryboard:@"BootSplash" rootView:rootView]; // ⬅️ initialize the splash screen
}
"expo": "51.0.15",
Yeah, Expo fixed compat issues with react-native-bootsplash, I have to ship v6 this weekend
@antFrancon After investigation, it appears that if the new expo release fix the issue with customizeRootView
, it also introduces a small regression with the internal splash screen module (?).
There is no issue with bare react-native 0.74.3.
EDIT: Using v6 beta, it works, but I still cannot apply the customizeRootView
patch, and has to stick with createRootViewWithBridge
still 😕
not sure whether https://github.com/expo/expo/pull/30245 helps for the issue?
@Kudo Yes, this is what missing! I though it was already supported, my bad.
Also, if called (or if expo-splash-screen is not installed), expo should not hide the added loadingView (UIView*).
it's my bad that to miss i have copied code inside expo. the fix is merged and should be published next week.
Also, if called (or if expo-splash-screen is not installed), expo should not hide the added loadingView (UIView*).
could you elaborate this case more? or a repro would be much appreciated. i tried the following stack and it doesn't appear problems. maybe i miss anything.
yarn create expo-app -t blank@@sdk-51 sdk51
yarn add react-native-bootsplash@^6.0.0-beta.9
RNBootSplash.initWithStoryboard
call from createRootViewWithBridge to customizeRootViewcould you elaborate this case more? or a repro would be much appreciated. i tried the following stack and it doesn't appear problems. maybe i miss anything.
I just didn't though too much before talking, the issue was that it's not called, not that expo remove the UIView 😅
This will fix it! Thanks a lot @Kudo
Expo 51.0.20
supports customizeRootView
, the latest beta includes the fix: https://github.com/zoontek/react-native-bootsplash/pull/578
Everything is finally ready for v6 stable 😮💨
Before submitting a new issue
Bug summary
After upgrading React Native to version
0.74.3
, the splash screen feature is broken on iOS.Specifically:
useHideAnimation
) no longer hides.This issue may be related to this commit in the last RN release: Support customizeRootView from RCTRootViewFactory.
Library version
5.5.3
Environment info
Steps to reproduce
I tested both in dev and release mode.
Reproducible sample code
Run the example including the
useHideAnimation
part.