Open demedos opened 6 hours ago
Because react-native-bootsplash now uses @expo/config-plugins
instead of a custom RegExp based implementation.
The issue is in the expo package, you should open an issue on their repository instead.
For the 3., see https://github.com/zoontek/react-native-bootsplash/issues/629
Before submitting a new issue
Bug summary
Hi, first of all, thanks for all the hard work on this package! ๐
I'm currently upgrading from version 4 to version 6 and noticed a few issues that might be worth addressing:
XML Comments Removal:
After the upgrade, I saw that comments in my XML files are being removed. This feels like a breaking change as it modifies the code beyond the expected scope of this package. It can potentially cause issues, especially for builds that rely on tools like Plop or custom scripts, which use comments as anchors to auto-generate content in specific parts of the code.
Code Prettification:
The code is being automatically prettified, which generates unnecessary and often unwanted diffs. This is a bit unexpected since the package should ideally only modify the parts of the code it needs to.
Question about Assets:
One thing I'm still trying to understand is, when generating for iOS and Android, whatโs the reason for generating the
assets/bootsplash
files? Maybe Iโm missing something obvious here! ๐Thanks again for your time and help! Would love to get some clarity or improvements around this. ๐
Library version
6.1.x
Environment info
Steps to reproduce
Steps to reproduce:
Before the upgrade (v4.5.2):
assets/bootsplash
files were generated.After the upgrade (v6.1.x):
assets/bootsplash
files are generated for both iOS and Android.Reproducible sample code