So I went ahead and checked out the function. I noticed that it uses self.handlers instead of _handlers - I assume that could be a reason for this crash because, in the prior line, we only check if if (_handlers != nil) { and we use _handlers respectively everywhere.
Test Plan
What's required for testing (prerequisites)?
What are the steps to test it (after prerequisites)?
Compatibility
OS
Implemented
iOS
✅❌
Android
✅❌
Checklist
[x] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I added a sample use of the API in the example project (example/App.tsx)
Hi! _handlers is actually just an alias for self.handlers, so I don't think this PR would have an impact.
But I can merge it as it's better consistency given the condition just above.
Summary
I've noticed the following crash in our app which is happening randomly:
So I went ahead and checked out the function. I noticed that it uses
self.handlers
instead of_handlers
- I assume that could be a reason for this crash because, in the prior line, we only check ifif (_handlers != nil) {
and we use_handlers
respectively everywhere.Test Plan
What's required for testing (prerequisites)?
What are the steps to test it (after prerequisites)?
Compatibility
Checklist
README.md
example/App.tsx
)