Target simple_markdown as the class to be more universal

zooppa / administrate-field-simple_markdown

✍️ A plugin to edit Markdown text in Administrate

https://github.com/thoughtbot/administrate

MIT License

8 stars 13 forks source link

Target simple_markdown as the class to be more universal #13

Closed jondkinney closed 4 years ago

jondkinney commented 4 years ago

Allow for rendering in a nested context

michelegera commented 4 years ago

Hey @jondkinney, thanks for your contribution!

I tried your branch locally against a test app, but unfortunately it breaks compatibility with another gem, administrate-field-nested_has_many that injects forms with (potentially) other markdown editors in them.

Do you have a particular use case or issue that this PR aimed to solve, or was it a general improvement?

michelegera commented 4 years ago

See https://github.com/zooppa/administrate-field-simple_markdown/issues/16#issuecomment-635353384.