Depends on unmaintained SimpleMDE

zooppa / administrate-field-simple_markdown

✍️ A plugin to edit Markdown text in Administrate

https://github.com/thoughtbot/administrate

MIT License

8 stars 13 forks source link

Depends on unmaintained SimpleMDE #9

Closed sedubois closed 4 years ago

sedubois commented 4 years ago

I would recommend fixing the hyperlink to SimpleMDE in the README, which currently points to a broken repo. It looks like the proper place is https://github.com/sparksuite/simplemde-markdown-editor (see discussion https://github.com/nextstepwebs/simplemde-markdown-editor/issues/1#issuecomment-375843973).
SimpleMDE is unmaintained since 4 years, maybe can be replaced by the fork EasyMDE https://github.com/Ionaru/easy-markdown-editor? In the future there might also be markdown support in Trix.

michelegera commented 4 years ago

Thanks for the heads up, I just fixed the link as suggested.

I am working on replacing SimpleMDE with EasyMDE, I should have a PR ready in a few days.

michelegera commented 4 years ago

Porting to EasyMDE is almost done, I am trying to troubleshoot an issue with FontAwesome icons not displaying.

michelegera commented 4 years ago

Actually, I figured it out 😄

I just pushed a branch with the porting, if you want you can try it by fetching the plugin directly from this repo:

# Gemfile

# Make sure you have the following line at the top of your Gemfile
# git_source(:github) { |repo| "https://github.com/#{repo}.git" }

gem 'administrate-field-simple_markdown', github: 'zooppa/administrate-field-simple_markdown', branch: 'switch-to-easymde'

sedubois commented 4 years ago

Thanks @michelegera, I gave the branch a try by loading one of my Post::Translations which have a content field of type Field::SimpleMarkdown, but the editor doesn't load it's just a standard textarea. The code is like this:

Can it still have anything to do with the fact that the model is namespaced?

michelegera commented 4 years ago

Closed via 3f00c2d1b2c8c3d25ac69772aa4b33ce2108b09c