Closed hub23 closed 8 years ago
You should remove the lineending and filespace changes.
No need to modify them just to suit style as it can disturbs git blame
.
Other then some small comments, 👍 Saves having to hack together a solution by polluting an environment variable.
You should remove the lineending and filespace changes.
I'm pretty new to git, that makes sense :grin:. I reverted the changes in new_smart_launch.sh.
I will update here if new changes are tested.
LGTM :+1:
Tested a few cases and almost everything is working :+1: except factorio.com login token.
hey, I'm accepting this bud only had time to read it quickly
As stated in Including server-settings.json #19, I would like to use the settings defined in
server-settings.json
. The needed settings can not be called by a parameter passed to the server binary, the fileserver-settings.json
must be used to set the values.Including these changes,
/opt/factorio/server-settings.json
will be generated and populated bycat
innew_smart_launch.sh
. If one or more variables are set while starting the container, theserver-settings.json
config file will be used to define additional settings by adding--server-settings /opt/factorio/server-settings.json
to$factorio_command
.The following parameters are passable at container start to define settings:
Conditions for execution of:
factorio_command="$factorio_command --server-settings /opt/factorio/server-settings.json"
Are the following:
The defaults (
/opt/factorio/data/server-settings.example.json
inzopanix/factorio:0.13.8
) for theserver-settings.json
to contain are:Some lines are hidden in this comment because of comments and braces.
If default values are missing from
server-settings.json
, the server wont start (Although I did not test one by one, just tested by removing "name", I assume all defaults are needed.).I changed the following values away from default because I think default factorio.com account verification for user login or public listing, which also requires factorio.com account, is not wanted by most users:
Required credentials for public listing can be supplied by setting
FACTORIO_USER_USERNAME
andFACTORIO_USER_PASSWORD
orFACTORIO_USER_TOKEN
variables. A check for public visibility withoutFACTORIO_USER_USERNAME
andFACTORIO_USER_PASSWORD
orFACTORIO_USER_TOKEN
defaults back to "hidden" when parameters are missing.