zopanix / docker_factorio_server

Factorio Server in Docker
MIT License
31 stars 275 forks source link

Add docker compose #28

Open RCM7 opened 8 years ago

RCM7 commented 8 years ago

Basically I added the docker-compose I usually use to spin up my game server.

This way all the mounts, port mapping, environment variables and build step is handled by docker-compose and specified in this file, reducing the size of the commands to something like:

docker-compose up -d
docker-compose down
docker-compose build

Any doubts just ask, but don't skip a look at the docker-compose documentation if you don't understand something.

Cheers

bkuhl commented 8 years ago

@zopanix The Travis-CI build is failing because the environment variables haven't been configured in travis. Can you set that up please?

zopanix commented 8 years ago

Hey, the env vars are set, it should work now

RCM7 commented 8 years ago

I don't believe using Travis CI is the best tool to build images automatically and put them in Docker Hub since Docker Hub themselves support github integration and automatic builds of images...

So unless Travis CI is running some tests on the image, I don't think it should be used at all.

bkuhl commented 8 years ago

The value Travis-CI adds over Dockerhub is that it can tag the images in accordance with the GitHub release version number. Dockerhub isn't capable of this kind of integration.

RCM7 commented 8 years ago

Beg to disagree. It is possible and they even show you how with examples in the page where you set it up

EDIT: screen shot 2016-08-08 at 21 46 02

bkuhl commented 8 years ago

You're totally right, I don't remember seeing this. This could replace the travis integration. The full docs are here: https://docs.docker.com/docker-hub/github/

zopanix commented 8 years ago

@RCM7 @bkuhl : I already tried using docker build tools but it didn't work that well. I don't have as many options as you show on your screenshot and, while everything is configured correctly, I've never seen an automated build starting on its own. That's why I've chosen travis ci to manage this. It might I don't get how it works :p

RCM7 commented 8 years ago

@zopanix I understand that. I tried to reproduce the steps in a dummy project, and while some may seem confusing, it all checked out and it works. If you'd give it a try I'm glad to help with anything :)

RCM7 commented 8 years ago

Ping 😄

bkuhl commented 8 years ago

Upgrading this would be on @zopanix unless he wants to give me access to the Dockerhub repo as well.

zopanix commented 8 years ago

Hey, sorry I've been inactive bud I'm getting installed in my new home. I moved to canada from France it will take me a week or two to be completely operationnal :)

RCM7 commented 7 years ago

Sorry for the delay, I was out in vacation and then too occupied catching up with work 😄