search

zopanix / docker_factorio_server

Factorio Server in Docker
MIT License
31 stars 274 forks source link

Unable to run latest builds #34

Open bkuhl opened 8 years ago

bkuhl commented 8 years ago

We're unable to run the 0.14 build. --latency-ms is no longer an option for the client given the rework of networking on Factorio. It looks like server-settings.json format may have changed as the smart launch is not building a usable file leading to the error Error util.cpp:57: /opt/factorio/server-settings.json(22): expected value when run.

duckman commented 8 years ago

It seems to not like the verify_user_identity being set by the variable. I didn't dig too much, but if I remove the variable and just put in false, it seems to work. I basically updated the config in the script with the latest, removed the --latency-ms stuff and hard set the verify_user_identity and everything is working. I would submit a pull request but the hard setting the verify_user_identity isn't ideal, but I thought I would share so that someone more qualified might take a crack at it. o7

bkuhl commented 8 years ago

I've disabled the automatic releasing of new versions until this repo is compatible with 0.14.

pokemane commented 8 years ago

Is the linked PR going to be the fix moving forward, then?

bkuhl commented 8 years ago

No, not fully. I think Duckman needs to submit a PR

bkuhl commented 7 years ago

@duckman Can you please submit a PR with your changes?

FreekingDean commented 7 years ago

Are you sure it doesn't just need quotes around it? :P

bkuhl commented 7 years ago

Yes, I'm sure.

FreekingDean commented 7 years ago

It seems, that by putting quotes around $FACTORIO_SERVER_VERIFY_IDENTITY in the config file template along with removing

--allow-commands --autosave-interval --autosave-slots

0.14.14 works!

I would submit a PR, but I don't think that just removing those commands is the best fix. It is fine for my needs, but it should be investigated if it is possible to add to the config file.

dtandersen commented 7 years ago

I gave up on command line switches and ENV and mounted server-config.json into the /opt/factorio/data folder. It ended up being simpler. On the other hand, you have to copy up the config file. I suppose it's a matter of taste.

https://github.com/dtandersen/docker_factorio_server/

niklas-dahl commented 7 years ago

Will this issue be resolved in the near future? just pulled the image and got the same error :(