Converting ImplicitAcquisitionWrapper to bytes

zopefoundation / Acquisition

Acquisition is a mechanism that allows objects to obtain attributes from the containment hierarchy they're in.

Other

12 stars 12 forks source link

Converting ImplicitAcquisitionWrapper to bytes #39

Closed icemac closed 5 years ago

icemac commented 5 years ago

Fixes #38.

icemac commented 5 years ago

This is strange:

Locally (Python 3.7) the broken test fails with AttributeError: __index__ but on TravisCI it fails with AttributeError: __getitem__. (Only Python 3.5 misses __getitem__ locally. Only Python 3.8 has AttributeError: __index__ on TravisCI.)
Locally the pure python version fails with a RecursionError but in TravisCI it has the same AttributeError: __getitem__ like the C version.

icemac commented 5 years ago

After changing the .travis.yml the pure Python 3.7 build fails with TypeError: cannot convert 'ImplicitAcquisitionWrapper' object to bytes. Which should be easily fixable.

icemac commented 5 years ago

@jamadden and @stephan-hof Thank you for analysing my C code. After reading your analysis it is totally clear that I played too much monkey see, monkey do.

icemac commented 5 years ago

Thank you everyone for helping to fix this issue.