When temporarily decoding an incoming attribute name from a unicode string, be careful not to destroy the temoporary PyObject until we're done using its char* buffer

zopefoundation / Acquisition

Acquisition is a mechanism that allows objects to obtain attributes from the containment hierarchy they're in.

Other

12 stars 12 forks source link

When temporarily decoding an incoming attribute name from a unicode string, be careful not to destroy the temoporary PyObject until we're done using its char* buffer #6

Closed jamadden closed 9 years ago

jamadden commented 9 years ago

Fixes zopefoundation/Acquisition#5, with luck.

tseaver commented 9 years ago

I'm sorry to ask, but can you find a way to split out the whitespace cleanups from the substantive change? Changes to C extensions are tricky enough to review without the extra noise. Even dividing them into two commits would be fine.

jamadden commented 9 years ago

Sorry about that. I often forget to turn that off in emacs. Too bad github doesn't have the equivalent of the '-w' option. Should be better now.

tseaver commented 9 years ago

Thank you!

davisagli commented 9 years ago

Too bad github doesn't have the equivalent of the '-w' option. Should be better now.

It does! Add ?w=1 to the URL to see the diff with whitespace changes ignored.

jamadden commented 9 years ago

@davisagli Thank you!