search

zopefoundation / DateTime

This package provides a DateTime data type, as known from Zope. Unless you need to communicate with Zope APIs, you're probably better off using Python's built-in datetime module.
Other
19 stars 25 forks source link

add ci and conda publish actions #21

Closed fcakyon closed 4 years ago

fcakyon commented 4 years ago

adds continious integration (on macos/linux/windows with python 3.5-8) and conda publish workflows using github actions

adds features:

requirements:

dataflake commented 4 years ago

I am strictly against adding yet another third party CI workflow unless this is discussed at the zopefoundation organization level and found to be OK for the whole zopefoundation organization.

fcakyon commented 4 years ago

I am strictly against adding yet another third party CI workflow unless this is discussed at the zopefoundation organization level and found to be OK for the whole zopefoundation organization.

What do you mean by "3rd party ci workflow"? It is based on official github actions.

jamadden commented 4 years ago

I concur with @dataflake.

dataflake commented 4 years ago

I am strictly against adding yet another third party CI workflow unless this is discussed at the zopefoundation organization level and found to be OK for the whole zopefoundation organization.

What do you mean by "3rd party ci workflow"? It is based on official github actions.

This "conda"/"anaconda" thing is a third party that we are not using on any other repository in the entire zopefoundation GitHub organization.

I'm sure you put a lot of effort into this, but changing infrastructure like CI workflows is out of the question without top-level decisions and plans/volunteers to roll that out across all repositories.

I will also note that signing the contributor agreement is a basic prerequisite for anything, and it appears you haven't done so?

fcakyon commented 4 years ago

I am strictly against adding yet another third party CI workflow unless this is discussed at the zopefoundation organization level and found to be OK for the whole zopefoundation organization.

What do you mean by "3rd party ci workflow"? It is based on official github actions.

This "conda"/"anaconda" thing is a third party that we are not using on any other repository in the entire zopefoundation GitHub organization.

I'm sure you put a lot of effort into this, but changing infrastructure like CI workflows is out of the question without top-level decisions and plans/volunteers to roll that out across all repositories.

I will also note that signing the contributor agreement is a basic prerequisite for anything, and it appears you haven't done so?

Anaconda cloud is a distribution framework similar to PYPI.

We want to publish pycaret (which requires your library) to anaconda cloud, however all dependencies should have a conda distribution build to do so. All required packages except "DateTime" and "datefinder" is present as a package in anaconda cloud. With this pull request, I am trying to add automatic conda publishing support to this repo.

How can I sign this contributor agreement?

dataflake commented 4 years ago

Information about becoming a contributor is at https://www.zope.org/developer/becoming-a-committer.html

I'm still unclear why you can't just download an egg file and upload it to wherever you need it if PyPI for some odd reason is not working. Why would the project need to support publishing to some place that is not the official Python package repository? Isn't this something you can do yourself?

fcakyon commented 4 years ago

Yes I have already published this project as a conda package. Thought that you would want to add official conda support. If you don't want it, it is OK.

If you ever consider adding conda support, you can use this workflow.

dataflake commented 4 years ago

Let's just say that in the 20+ year history of this code (and any other Zope package that I am involved in) there hasn't been any request to publish packages in other places than PyPI. If there was high demand from various parties, maybe. But until then I suggest you publish what you need by hand.