zopefoundation / DateTime

This package provides a DateTime data type, as known from Zope. Unless you need to communicate with Zope APIs, you're probably better off using Python's built-in datetime module.
Other
19 stars 25 forks source link

fix #39 #40

Closed d-maurer closed 2 years ago

d-maurer commented 2 years ago

Fixes #39 by avoiding the - format modifier (not suppoted by all C libraries)-

d-maurer commented 2 years ago

The Windows tests fail -- but already during the test run setup:

py310 run-test-pre: commands[0] | 'D:\a\DateTime\DateTime\.tox\py310\Scripts/buildout' -nc 'D:\a\DateTime\DateTime/buildout.cfg' 'buildout:directory=D:\a\DateTime\DateTime\.tox\py310' 'buildout:develop=D:\a\DateTime\DateTime' install test
Requires-Python support missing. 

Traceback (most recent call last):
  File "D:\a\DateTime\DateTime\.tox\py310\lib\site-packages\zc\buildout\patches.py", line 52, in patch_PackageIndex
    from pip._internal.index.collector import HTMLPage
ImportError: cannot import name 'HTMLPage' from 'pip._internal.index.collector' 
dataflake commented 2 years ago

The pip issue is not what causes the failure. I "forced" a fix for the pip issue by downgrading to a version < 22 and the test failure still shows. I don't know why there is no informative text output, though.

d-maurer commented 2 years ago

Jens Vagelpohl wrote at 2022-9-9 03:08 -0700:

The pip issue is not what causes the failure. I "forced" a fix for the pip issue by downgrading to a version < 22 and the test failure still shows. I don't know why there is no informative text output, though.

The py310 test run fails with exit exit code 2. This may indicate a "special" test run failure.

d-maurer commented 2 years ago

Dieter Maurer wrote at 2022-9-9 12:17 +0200:

Jens Vagelpohl wrote at 2022-9-9 03:08 -0700:

The pip issue is not what causes the failure. I "forced" a fix for the pip issue by downgrading to a version < 22 and the test failure still shows. I don't know why there is no informative text output, though.

The py310 test run fails with exit exit code 2. This may indicate a "special" test run failure.

zope.testrunner will not use exit code 2 (at least not to indicate a failed test): its run function has body

    failed = run_internal(defaults, args, script_parts=script_parts, cwd=cwd,
                          warnings=warnings)
    sys.exit(int(failed))

where failed has a boolean value.

This suggests: the exit code comes from something prior to the activation of zope.testrunner.

dataflake commented 2 years ago

I think I see the problem. zc.buildout is creating the test script at bin\test but then tox wants to run it from Scripts\test. I'm trying to fix that now.