The manage main page should be update to the new Zope 4 conventions

zopefoundation / Products.BTreeFolder2

A BTree based implementation for Zope's OFS.

Other

3 stars 8 forks source link

Closed ale-rt closed 3 years ago

ale-rt commented 3 years ago

I browsed to https://demo.plone.org/es/manage_main and noticed that the page template should be updated for Zope4.

Products.BTreeFolder2 = 4.2

Plone 5.2.3 (5210) CMF 2.4.8 Zope 4.5.3 Python 3.8.3 (default, Jul 14 2020, 07:39:54) [GCC 7.5.0] PIL 6.2.2 (Pillow) WSGI: On Server: waitress 1.4.4

ale-rt commented 3 years ago

dataflake commented 3 years ago

To just make that notice go away it should be sufficient to enclose the content area of the template in the <main class="container-fluid"> tag.

ale-rt commented 3 years ago

Thanks @dataflake I can do an initial PR that does just that. But I think there are some other things to do right? For example:

there is a redundant add form (see screenshot below)
I was thinking about changing the table element to use bootstrap classes https://github.com/zopefoundation/Products.BTreeFolder2/blob/3b009b10890f3541098f4d83d4c7c3cfb3841894/src/Products/BTreeFolder2/contents.dtml#L45
some other css adjustment if needed

Do you want me to make a PR that just adds the wrapping main element and maybe address the other issues in different issues?

dataflake commented 3 years ago

Sure, you're welcome to make as many changes as you like. I was just suggesting the simplest way to fix that message 😉