- Update manage_main.dtml to Zope 2.13 version to restore ZMI icons

zopefoundation / Products.ExternalEditor

Other

2 stars 6 forks source link

- Update manage_main.dtml to Zope 2.13 version to restore ZMI icons #6

Closed dataflake closed 7 years ago

mauritsvanrees commented 7 years ago

I have not tried it, but this would break compatibility with Zope 4, right? The master branch is meant for Zope 4. With Zope 2.13 you should use Products.ExternalEditor branch 1.1.x.

I don't quite know how you should have been able to know this, except that Plone's buildout.coredev uses Products.ExternalEditor 1.1.3 except in the Zope 4 plip config. So an update to the readme may be helpful.

dataflake commented 7 years ago

Hi Maurits, good point, and no, it was not obvious which ExternalEditor version is supposed to work with which Zope version. I'll take a look some time today and do a trial install in a Zope 4 environment to see how the patch behaves. If there are any issues I'll do a new PR with a simple documentation update.

dataflake commented 7 years ago

OK, this doesn't work under Zope 4 - I'll close this PR and change the README instead.