search

zopefoundation / Products.ExternalEditor

Other
2 stars 6 forks source link

Prepare for Python 2 / 3 compatibility (1.1.x branch) #9

Closed davilima6 closed 6 years ago

davilima6 commented 6 years ago

@mauritsvanrees, could you please help me testing those? How should I run tests locally and on Jenkins?

mauritsvanrees commented 6 years ago

I see that Jenkins does not run any tests for this. Well, plone.app.testing does load its zcml, so a passing Jenkins job would at least make sure that Plone can start up with these changes. I see no testing support for this in the Zope/Zope2 repo. Maybe you could add a simple buildout. Products.PluginRegistry could be an example.

icemac commented 6 years ago

@davilima6 I'm not sure if this port is needed. According to README.rst the 1.1 branch is for Zope 2.x which will not be ported to Python 3.

icemac commented 6 years ago

@davilima6 See #10 where I added testing support for this package.