Closed rudaporto closed 6 years ago
@tomgross I update with more compatible changes.
Still, there is some unused imports but I did not removed them at this stage.
@tomgross should I change travis.yaml to use tox run the build with python 2.7, 3.4, 3.5 and 3.6?
@rudaporto This package depends on GenericSetup (Python 3 upgrade is WIP) and ZServer (This package will probably never see Python 3)
To get an overview what is achieved it is probably a good idea to have them with allow_failures
option on.
I don't know, if there is an official statement on Python 3 subversion compatibility but I'd focus on 3.5 and 3.6.
Maybe it is a good idea to have coveralls run too to see where the blind spots are.
Apart from that this LGTM.
We should make the dependency on ZServer
optional. The dependency is there to support detection of an FTPRequest
, but if ZServer
is not installed, we can just create a no-op class, e.g.:
# in Products/PluggableAuthService/plugins/RequestTypeSniffer.py
try:
from ZServer.FTPRequest import FTPReques
except ImportError:
class FTPRequest(object):
"""Dummy for missing ZServer's 'FTPRequest'."""
@tseaver +1 to make ZServer optional, some weeks ago I created #8 to address this issue. Maybe it can be done in another PR.
What has still to be done to get this PR merged?
@pbauer can you help me with this review or should I ask someone else?