zopefoundation / Products.PluggableAuthService

Pluggable Zope authentication / authorization framework
Other
9 stars 18 forks source link

Pass user name as login to updateCredentials - fix #105 #106

Closed d-maurer closed 2 years ago

d-maurer commented 2 years ago

updateCredentials usually works together with extractCredentials. extractCredentials usually does not know user ids - they become only known after authentication. Therefore, the login parameter of updateCredentials must refer to the user name (which actually is the login name) and not the user id -- as the name login suggests. In #105 @rpatterson reported a violation of this condition in events.userCredentialsUpdatedHandler.

This PR fixes #105. It also fixes the docstring of PluggableAuthService._extractUserIds.