updateCredentials usually works together with extractCredentials. extractCredentials usually does not know user ids - they become only known after authentication. Therefore, the login parameter of updateCredentials must refer to the user name (which actually is the login name) and not the user id -- as the name login suggests.
In #105 @rpatterson reported a violation of this condition in events.userCredentialsUpdatedHandler.
This PR fixes #105.
It also fixes the docstring of PluggableAuthService._extractUserIds.
updateCredentials
usually works together withextractCredentials
.extractCredentials
usually does not know user ids - they become only known after authentication. Therefore, thelogin
parameter ofupdateCredentials
must refer to the user name (which actually is the login name) and not the user id -- as the namelogin
suggests. In #105 @rpatterson reported a violation of this condition inevents.userCredentialsUpdatedHandler
.This PR fixes #105. It also fixes the docstring of
PluggableAuthService._extractUserIds
.