Fix ZMI Templates for Groups/Users/Roles

zopefoundation / Products.PluggableAuthService

Pluggable Zope authentication / authorization framework

Other

9 stars 18 forks source link

Fix ZMI Templates for Groups/Users/Roles #36

Closed petschki closed 5 years ago

petschki commented 5 years ago

@dataflake thank you for the review. I've changed the wording of the button.

Multiple icons are strange. I could not reproduce that. Though I've changed the <i> tag closing as you suggested.

The new commit is mainly table class cleanup and I've remove the here/manage_tabs from every modal add form. But I think this could need a bit more cleanup, because the Design Hint is still there because of the missing <main> block ...

dataflake commented 5 years ago

I may be able to help out a bit more today or tomorrow.

After encountering the double icons during similar work on Products.PluginRegistry I looked at the documentation and noticed they all use explicitly closed </i> in their examples. And in that case it made it work for me as well. Maybe a browser issue.