Add events for adding/removing principals to/from groups

zopefoundation / Products.PluggableAuthService

Pluggable Zope authentication / authorization framework

Other

9 stars 18 forks source link

Add events for adding/removing principals to/from groups #58

Closed dataflake closed 4 years ago

dataflake commented 4 years ago

Fixes #17

This PR replaces #21 because I want this finished and don't want to go through the hoops of getting access to a fork.

I believe all concerns raised in #21 are addressed in this branch, I added tests and changed the argument names to make clear that we are talking about strings and not principal instances. I did not apply this change to the principal argument itself to stay conformant with the base class IPASEvent.

dataflake commented 4 years ago

@ale-rt Thank you for jumping on this so quickly. I'll create 1.11.3 now and then merge all this into master