search

zopefoundation / Products.PluggableAuthService

Pluggable Zope authentication / authorization framework
Other
9 stars 18 forks source link

Fix broken relative imports in Extensions/upgrade.py #73

Closed mauritsvanrees closed 4 years ago

mauritsvanrees commented 4 years ago

And add basic tests for this file, so an ImportError will get caught a next time.

jugmac00 commented 4 years ago

@mauritsvanrees Sorry for the broken imports! Changing the existing absolute imports to relative imports just to please isort and flake8s line length norm was certainly no good idea, especially not when there is no complete test coverage.

Thanks for fixing it and writing some tests!

dataflake commented 4 years ago

Changing absolute to relative imports is still a good idea because it is a very obvious visual cue that the import is from the same package.