simple alternative lookup mechanism for SAWrapper DA instances

zopefoundation / Products.SQLAlchemyDA

SQLAlchemyDA is a generic database adapter for ZSQL methods. Since it is based on SQLAlchemy, SQLAlchemyDA supports all databases out-of-the box that are supported by SQLAlchemy (Postgres, MySQL, Oracle, SQLite, MS-SQL, Firebird, Informix).

Other

2 stars 10 forks source link

simple alternative lookup mechanism for SAWrapper DA instances #3

Closed sheilatron closed 9 years ago

sheilatron commented 9 years ago

Please take a look and let me know if you have any suggestions before this change is released. It should be backward compatible, not changing internals, but expands the public API. See CHANGES.txt for details.

I'm hoping for review from @zopyx but am not sure if he will be available; looping in @tseaver , or @xanalogica . At work we have an internal release due at end of this week which depends on this new API, so I would like to release this week.

sheilatron commented 9 years ago

Thanks for all the inputs; I didn't spot this until just before bedtime, so will dig into it tomorrow.

sheilatron commented 9 years ago

Hi @tseaver, I followed your recommendations, added more test coverage and docs, along with a few other tweaks. We need to release this internally at work ASAP, though I would also like to go ahead and release on PyPI. Please let me know what you think. Thanks!