search

zopefoundation / Products.ZCatalog

Zope's indexing and search solution.
Other
5 stars 22 forks source link

Fix linting issues #106

Closed jugmac00 closed 4 years ago

jugmac00 commented 4 years ago

... which came with the new flake8 version.

I'd like some advice on what to do what to do when a parameter has to be changed, like the lowercase l in some places here.

The functions are at module level, so I consider them to be public API and I hesitate to rename their parameters in order to not break code which relies on them.

Should we create a deprecation warning? If so, please hint to some source code where this is done already.

Thanks for you input!

icemac commented 4 years ago

I think the noqa makers are okay for now.

jugmac00 commented 4 years ago

Ready for review.