search

zopefoundation / Products.ZCatalog

Zope's indexing and search solution.
Other
5 stars 22 forks source link

Refactored ZMI templates for Zope4+ #128

Closed drfho closed 2 years ago

drfho commented 2 years ago

Hi @dataflake , I fitted ZCatalog-ZMI pages, which did not contain all the necessary CSS classes needed for a nice Zope look. Following tabs are refreshed now:

Screen Image: Left: former ZMI, right: refreshed ZMI ZCatalog_ZMI

A small side effect to be discussed: Historically the Zope default CSS zmi.base.css compensates some super-bad layout effects of the non-bootrappyfied ZCatalog ZMI. These 3 elements are not needed anymore for Zope: https://github.com/zopefoundation/Zope/blob/b72715cf01cce1a49b59198047113f29f89037c5/src/zmi/styles/resources/zmi_base.css#L891-L905 But many installations may not use the latest ZCatalog, so I added a CSS snippet into ZCatalog/dtml/catalogView.dtml Line134+ for neutralizing the upper Zope CSS dealing with the former non-conformance to a strict styling. Please tell me, if you prefer removing it both from Zope an ZCatalog.

drfho commented 2 years ago

Instead of showing cataloged object info as a new window (and loosing the UI context) it is shown now as a modal popup:

ZCatalog_ZMI2

dataflake commented 2 years ago

All these ideas are good (and I'd suggest leaving the superfluous CSS instead of breaking some installations), but I'd be so much happier if you could teach your HTML editor to not use tab characters for indentation. Tabs are forbidden in our Python code and I wish we could get rid of them everywhere else as well.

drfho commented 2 years ago

Many thanks for the quick feedback Please excuse using tabs (to me tabs just were easier to handle). Actually I forgot/didnt know, that tabs are forbidden in the zope project. I will change it, when touching any code next time: https://github.com/zopefoundation/Products.ZCatalog/pull/128/commits/abd13343aa78ad86726886f434cc534ec6fd79a0