search

zopefoundation / Products.ZCatalog

Zope's indexing and search solution.
Other
5 stars 22 forks source link

Drop support for Python 3.7. #153

Closed icemac closed 2 months ago

icemac commented 2 months ago

Additionally to the broken MacOS jobs the code for setting the branch protection rules seems to be wrong here.

dataflake commented 2 months ago

Looks like this is the first zope-product project that has set with-macos = true other than Zope itself. Obviously, there's a bug. But is it really necessary to run macOS tests here?

dataflake commented 2 months ago

P.S.: @tseaver had a good point recently that running a bunch of tests that aren't really important are a waste of energy. We're continuing to do that in many places because we're not paying for it.

icemac commented 2 months ago

Testing on MacOS was added in #141 because of the bug in #140. It seems to behave differently that's why we are testing it.

icemac commented 2 months ago

Note: I do not plan to work on fixing this PR.

dataflake commented 2 months ago

I will fix it.

dataflake commented 2 months ago

The fix for macOS is the same as already used for Zope itself: C-based packages must be pre-installed with pip because zc.buildout/setuptools messes it all up. This dependency pre-install might be moved from individual packages' meta configuration into the meta templates itself, if I encounter another package like that I'll handle it.

icemac commented 2 months ago

Thank you for working on this PR. 😃