Closed sneridagh closed 4 years ago
@jensens @pbauer what's the process for this? Can we merge this PR now? Who is responsible for making releases for Zope?
Afaik there are no written rules, ie no real contributor documentation, which would be pretty good idea to create. Maybe at the next sprint, @icemac ?
Usually, there are these prerequisites:
That's the bare minimum.
Usually, for non trivial changes the reviewer should have a good knowledge of the package.
I think @d-maurer is the one with really deep knowledge about the ZCatalog, at least I would ask him for changes in the ZCatalog.
Responsible for Releases There are no fixed releasers in the Zope community. You usually have to lookup the releaser of a package on PyPi and ask them. https://pypi.org/project/Products.ZCatalog/
@hannosch is pretty much inactive, @tseaver answers occasional questions, but the other two are very active.
Thanks for the heads up @jugmac00! @sneridagh has signed the contributor agreement and we have three PR reviews. I guess we are good to merge then.
@dataflake @icemac would it be possible to get a release that includes this merge?
I just released https://pypi.org/project/Products.ZCatalog/5.1/.
Thanks a lot @icemac !
Awesome! Thank you @icemac!
See #98