Memory leak on Shared.DC.ZRDB.Results

zopefoundation / Products.ZSQLMethods

SQL method support for Zope.

Other

3 stars 14 forks source link

Memory leak on Shared.DC.ZRDB.Results #10

Open jordic opened 5 years ago

jordic commented 5 years ago

https://bugs.launchpad.net/products.zsqlmethods/+bug/143917

I want to fix this bug. (Any hints?) Where I should start? Which path should I take?

tseaver commented 5 years ago

@jordic The obvious "fix" is just to remove the aliases: applying that fix would mean breaking user code which spelled columns differently than in the original SQL.

If we made that change, we would need to call it out very clearly in the changlog, such that users knew how to fix the errors it produced in their already running apps.

micha137 commented 5 years ago

One could have a switch defaulting to the old behaviour and a warning about the leaks. Whoever cares may switch to the new behaviour without aliases.