search

zopefoundation / Products.ZSQLMethods

SQL method support for Zope.
Other
3 stars 14 forks source link

Depend on DocumentTemplate 2.13.5+ to do SQL quoting. [2.13] #21

Closed mauritsvanrees closed 4 years ago

mauritsvanrees commented 4 years ago

Note: because of that dependency it might be better to use Zope 2.13, although technically we only require 2.12 minimum.

The test file was copied without change from the master branch, with the latest fixes.

(Note: Products.PythonScripts will need similar fixes, but I will leave that for another day.)

dataflake commented 4 years ago

Version 2.13.6 is on PyPI now.

mauritsvanrees commented 4 years ago

Note: as I wrote above, I thought that Products.PythonScripts would need similar fixes, but that is not true: it simple imports the sql_quote function from DocumentTemplate and declares it public so you can import it in TTW PythonScripts. It does not do anything else with it, so nothing more needs to be done. The Zope part of the Plone hotfix has been taken care of.

dataflake commented 4 years ago

I still have to update the published dependency lists for Zope master and 4.x, will do that today. You also still need that Zope 2.13 release, correct?

mauritsvanrees commented 4 years ago

Correct, we need that for Plone 4.3 and 5.1. On the other hand, actually nothing has changed on the Zope 2.13 branch, so a new release of that package is not strictly needed. We can just add version pins for the two new releases, like I did here for 4.3.

Also, having an official versions list of Zope 2.13 is nice, but for hysterical reasons Plone is not using it. Plone 4.3/5.1 use an own mangled copy of 2.13.27 still, with overrides to get 2.13.29 and several far newer packages like AccessControl 3. See partially issue https://github.com/plone/buildout.coredev/issues/462. It is messy.

Anyway, from Plone 5.2 onwards we follow the official Zope versions better, so updated files for Zope 4 and master would be good.

dataflake commented 4 years ago

The updated version information is now live on https://zopefoundation.github.io/Zope/