search

zopefoundation / Products.ZSQLMethods

SQL method support for Zope.
Other
3 stars 14 forks source link

ZMI: monotonized paging buttons #28

Closed drfho closed 4 years ago

drfho commented 4 years ago

hi @dataflake, the paging buttons are monotonized now to the style used for history. Moreover a UX issue is fixed when paging through the database results (table stays in viewport) Yesterday I did not see the discrepancy of the buttons styles; sorry for that incovenience,

paging

drfho commented 4 years ago

The only thing I wasn't sure about is the behavior when pressing the query submit button. Did you want to jump to the results immediately or (the way it works right now) only when someone uses the pagination buttons?

Not when entering the page, but when walking through the table. Actually this it is, how it works with Win-Browsers (we wll revise the JS).

dataflake commented 4 years ago

No need for any changes - this was just my misunderstanding of when you want to activate that jump. It does work fine when walking the table.

drfho commented 4 years ago

sorry, just added the change: Actually it's better this way, because URL is not manupulated. Feel free to take it. Thanks for the input.

dataflake commented 4 years ago

Is there anything else you're working on in this package? If there's no other changes or PRs I can make a release, otherwise I will wait.

drfho commented 4 years ago

👍 I am done .... for now

dataflake commented 4 years ago

I just released version 3.11. Thanks for continuing to do this work. Anything that makes the ZMI nicer has a direct impact on me and my team in my main project, which is very ZMI-centric.