f-String instead of template

zopefoundation / RestrictedPython

A restricted execution environment for Python to run untrusted code.

http://restrictedpython.readthedocs.io/

Other

456 stars 38 forks source link

f-String instead of template #244

Closed loechel closed 1 year ago

loechel commented 1 year ago

At the moment it is just a prove that you can change the implementation to newer Python Version supporting syntax and enable use cases as described in #241

eric-cpp commented 1 year ago

Any ETA when this can be merged, please?

dataflake commented 1 year ago

I wonder if there are users that customized the template by monkey-patching that syntax_error_template variable itself, which would immediately break with this change. Or, in other words, the change as it is is backwards-incompatible. In all other packages we normally add a deprecation warning before just removing stuff.

dataflake commented 1 year ago

The OP has closed #241 because there is a workable solution that does not involve code changes on our end. I propose we close this PR.