zopefoundation / Zope

Zope is an open-source web application server.
https://zope.readthedocs.io
Other
352 stars 99 forks source link

Pin flake8 and plugins #826

Open icemac opened 4 years ago

icemac commented 4 years ago

823 arose because flake8 and its plug-ins are not pinned in constraints.txt.

To prevent such surprises in the future I suggest to pin every package used in tox.ini in versions.cfg so it gets propagated to constraints.txt. This makes requirements.txt more useless because it then will install too many things not needed to run Zope. Maybe we should drop requirements.txt completely.

dataflake commented 4 years ago

Don't forget that this may be the first time this ever happened (unpinned requirements from tox.ini breeaking things). Maybe this is for another day when we see it again.