search

zopefoundation / grokproject

Script that creates a Grok project directory, installs Grok, the Grok Toolkit and the Zope Toolkit and sets up a complete skeleton for a new Grok web application.
Other
2 stars 8 forks source link

PyPI release of 2.10 #5

Closed prsephton closed 7 years ago

prsephton commented 7 years ago

@janwijbrand Can we push version 2.10 to PyPI please? Current 2.9 on PyPI is broken :-)

janwijbrand commented 7 years ago

will do

janwijbrand commented 7 years ago

Done. Note the mistake in the CHANGES.txt. I had zest.releaser bump the version info for me. I did not realize you did that manually before. So version 2.10 is mentioned twice in the CHANGES.txt. Not a big problem for now. I'll clean up CHANGES.txt for subsequent releases.

prsephton commented 7 years ago

Thanks Jan,

I'm sorry, but there is a problem introduced in 2.10; The use of six.moves to import urllib introduced an incompatible read() result, leading to the Grok version number being escaped. In short, using six.moves broke things.

Unfortunately it did not break the unit tests. I have merged the fix.

janwijbrand commented 7 years ago

Can you update changes.txt too and then I can release 2.11

prsephton commented 7 years ago

Sure! will do that shortly.

prsephton commented 7 years ago

Merged changes.txt

janwijbrand commented 7 years ago

@prsephton you not need to update the version numbers and release dates in the CHANGES.txt yourself. That is done in the actual release process. What is important though is to keep the changelog up to date. I'm using zest.releaser that then will do all the necessary version bumps, release dates and tagging.

I'll release 2.11 and upload it to pypi.

janwijbrand commented 7 years ago

done.

prsephton commented 7 years ago

Thanks Jan!

On Fri, Oct 27, 2017 at 8:47 AM, Jan-Wijbrand Kolman < notifications@github.com> wrote:

done.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zopefoundation/grokproject/issues/5#issuecomment-339887719, or mute the thread https://github.com/notifications/unsubscribe-auth/ABaPXK0Fl_VwV2Ach4OP5okKjdsM1eetks5swXyBgaJpZM4QGeUP .