Fully test the C implementation of the PickleCache - Githubissues

zopefoundation / persistent

automatic persistence for Python objects

https://pypi.org/project/persistent/

Other

46 stars 28 forks source link

Fully test the C implementation of the PickleCache #105

Closed jamadden closed 5 years ago

jamadden commented 5 years ago

Fix discrepancies between it and the Python implementation:

The C implementation now raises ValueError instead of AssertionError for certain types of bad inputs.
The Python implementation uses the C wording for error messages.
The C implementation properly implements IPickleCache; methods unique to the Python implementation were moved to IExtendedPickleCache.
The Python implementation raises AttributeError if a persistent class doesn't have a p_jar attribute.

Fixes #102

jamadden commented 5 years ago

Thanks! (FWIW, I also ran the ZODB tests with this without issue.)