zopefoundation / persistent

automatic persistence for Python objects
https://pypi.org/project/persistent/
Other
46 stars 28 forks source link

Use Py_ssize_t for length arguments of PyArg_ParseTuple #109

Closed mgedmin closed 5 years ago

mgedmin commented 5 years ago

This API was introduced in Python 2.5 and the old one (using ints) has been deprecated since Python 3.8.

Fixes #108.

Somebody who actually knows the Python C API please review this, because I just pretend I know C.

mgedmin commented 5 years ago

This fixes all the deprecation warnings I saw with tox -e py38 on Python 3.8.0a3.

git grep [a-z]# seems to confirm that there are no more #-arguments in the codebase.

jamadden commented 5 years ago

I think the changes here are small and obvious enough that this is meregable.

icemac commented 5 years ago

@mgedmin @jamadden Do yo think it's time for a release? There are some features queued up in the change log.

I could do the release myself if I get PyPI rights (icemac).

mgedmin commented 5 years ago

I could do the release myself if I get PyPI rights (icemac).

You have them now.