search

zopefoundation / persistent

automatic persistence for Python objects
https://pypi.org/project/persistent/
Other
46 stars 28 forks source link

Stop calling gc.collect in the Python incrgc. #47

Closed jamadden closed 7 years ago

jamadden commented 8 years ago

@jimfulton and I have talked about it, and I'm (mostly :) convinced that this shouldn't be an actual problem for any of the reasons described in the previous comment.

Running the GC every time slows down one of Jim's benchmarks by up to 10x. It all depends on the frequency of the transactions relative to application work.

If I use PyPy 5.4.1 to run the ZODB master test suite against this (well, with #44 rolled back) I don't get any unexpected failures. (I haven't run the ZEO test suite yet.) Which honestly amazes me because I'm sure I used to get test failures---I guess the PyPy GC has changed...which means we may see some failures on Travis. I'll try to set up an older PyPy to verify.

(ZODB tests won't run with current master until #44 is addressed somehow.)

jamadden commented 8 years ago

64-bit Appveyor tests have been failing since #31 was merged.

jamadden commented 8 years ago

The Mac builds are failing to even start because of homebrew problems. I saw this on another zope project IIRC. I have no idea what causes it or what to do about it.

jamadden commented 8 years ago

I ran the ZODB test suite with PyPy 2.5.0 and no issues. I couldn't run the ZEO test suite with that old of a PyPy but it ran fine with PyPy2 5.4.1.

jamadden commented 7 years ago

Fixed by #54

jimfulton commented 7 years ago

Why was this closed?

jimfulton commented 7 years ago

Oh, nm