zopefoundation / persistent

automatic persistence for Python objects
https://pypi.org/project/persistent/
Other
46 stars 28 forks source link

Switch to zope.testrunner from 'python setup.py test' and 'nose'. #78

Closed jamadden closed 6 years ago

jamadden commented 6 years ago

Both are essentially deprecated. This is a step in producing usable coverage numbers.

Since we support PURE_PYTHON at runtime, always build the C extensions on supported platforms so that they go in the wheel. This avoids any issue with polluting the wheel cache.

(Also remove cp33 from the manylinux build. This was missed in https://github.com/zopefoundation/persistent/pull/74)

tseaver commented 6 years ago

Appveyor is failing on Python 3.4:

echo "C:\Program Files\Microsoft SDKs\Windows\v7.1\Bin\SetEnv.cmd" /x64 > "C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\bin\amd64\vcvars64.bat"
pip install -e .
Obtaining file:///C:/projects/persistent
    Complete output from command python setup.py egg_info:
    error in persistent setup command: 'extras_require' must be a dictionary whose values are strings or lists of strings containing valid project/version requirement specifiers.

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in C:\projects\persistent\
You are using pip version 10.0.1, however version 18.0 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.
jamadden commented 6 years ago

Thanks! Turned out I'd completely forgetten to do anything with appveyor.yml.

jamadden commented 6 years ago

All green now.

jamadden commented 6 years ago

Thanks!